Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md #2960

Merged
merged 11 commits into from
Aug 1, 2022
Merged

Add README.md #2960

merged 11 commits into from
Aug 1, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jul 29, 2022

This is a finale of

Addressed feedback from prev PRs:

  • instead of throwing an error on the dummy context function, I just provide null as the default value
  • clear method
  • actions.filter → actions.every

Screenshot from 2022-07-29 14-26-12
Screenshot from 2022-07-29 14-26-38
Screenshot from 2022-07-29 14-26-51

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2960 (e1ab582) into master (8205951) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2960      +/-   ##
==========================================
- Coverage   38.95%   38.95%   -0.01%     
==========================================
  Files         615      615              
  Lines       27457    27462       +5     
  Branches     4001     4003       +2     
==========================================
  Hits        10697    10697              
- Misses      15623    15629       +6     
+ Partials     1137     1136       -1     
Flag Coverage Δ
api-python 90.71% <ø> (ø)
catalog 12.23% <0.00%> (-0.01%) ⬇️
lambda 87.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/FileEditor/FileEditor.tsx 0.00% <0.00%> (ø)
catalog/app/containers/AddToPackage/Provider.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <ø> (ø)
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% <0.00%> (ø)
...log/app/containers/Bucket/PackageDialog/actions.ts 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <ø> (ø)
catalog/app/containers/Bucket/Summary.js 0.00% <0.00%> (ø)
catalog/app/embed/Dir.js 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fiskus fiskus requested a review from nl0 July 29, 2022 11:30
nl0
nl0 previously approved these changes Jul 29, 2022
@fiskus
Copy link
Member Author

fiskus commented Jul 29, 2022

I removed "Add Readme" button from nested directories inside the package. We can, potentially, add Readme there too, but it needs more development and thoughts

@fiskus fiskus requested a review from nl0 July 29, 2022 15:34
@fiskus fiskus merged commit fe2c6b2 into master Aug 1, 2022
@fiskus fiskus deleted the add-readme branch August 1, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants